Стилизация #4
Merged
Стилизация #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
♻️ Я собрал ваш пулреквест. Посмотреть можно здесь. |
Director099
reviewed
Dec 2, 2024
| } | ||
|
|
||
| .additional-goods__title { | ||
| font-family: "Oswald", sans-serif; |
source/less/blocks/advantages.less
Outdated
|
|
||
| .advantages__title { | ||
| margin: 0; | ||
| font-family: "Oswald", sans-serif; |
There was a problem hiding this comment.
Все шрифты в переменную, так будет тебе проще)
Принцип DRY не повторятся
source/less/blocks/page.less
Outdated
Comment on lines
1
to
23
| @font-face { | ||
| font-family: "Oswald"; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url("../../fonts/oswald/oswaldregular.woff2") format("woff2"); | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: "Oswald"; | ||
| font-style: normal; | ||
| font-weight: 500; | ||
| src: url("../../fonts/oswald/oswaldmedium.woff2") format("woff2"); | ||
| font-display: swap; | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: "Lato"; | ||
| font-style: normal; | ||
| font-weight: 400; | ||
| src: url("../../fonts/lato/Lato-Regular.woff2") format("woff2"); | ||
| font-display: swap; | ||
| } |
source/less/blocks/page.less
Outdated
Comment on lines
38
to
55
| .page { | ||
| height: 100%; | ||
| background-color: #E5E5E5; | ||
| } | ||
|
|
||
| .page__body { | ||
| display: flex; | ||
| flex-direction: column; | ||
| min-height: 100%; | ||
| margin: 0 auto; | ||
| font-family: "Lato", sans-serif; | ||
| font-weight: 400; | ||
| font-size: 14px; | ||
| line-height: 18px; | ||
| color: #444444; | ||
| background-color: #FFFFFF; | ||
| width: 320px; | ||
| } |
source/less/blocks/page.less
Outdated
Comment on lines
25
to
36
| .visually-hidden { | ||
| position: absolute; | ||
| width: 1px; | ||
| height: 1px; | ||
| margin: -1px; | ||
| border: 0; | ||
| padding: 0; | ||
| white-space: nowrap; | ||
| clip-path: inset(100%); | ||
| clip: rect(0 0 0 0); | ||
| overflow: hidden; | ||
| } |
source/less/blocks/page.less
Outdated
| line-height: 18px; | ||
| color: #444444; | ||
| background-color: #FFFFFF; | ||
| width: 320px; |
There was a problem hiding this comment.
Надо убрать)
у нас будет центровщик чтоб цвета протягивались, а контент был по середине
There was a problem hiding this comment.
неее.....
- то что можно нарисовать на css делаем на css
- либо экспортируешь единую картинку с наложением, либо css
Director099
reviewed
Dec 2, 2024
| font-display: swap; | ||
| } | ||
|
|
||
| @oswald: "Oswald", sans-serif; |
There was a problem hiding this comment.
Создай файл variables.less (Еще позже добавим переменные))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎓 Стилизация
💥 https://htmlacademy-adaptive.github.io/2553233-cat-energy-1/4/